Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sample code for delete document schema #3375

Closed
wants to merge 42 commits into from
Closed

feat: add sample code for delete document schema #3375

wants to merge 42 commits into from

Conversation

paulinawins
Copy link
Contributor

@paulinawins paulinawins commented Aug 1, 2023

Description

Fixes #issue

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@paulinawins paulinawins requested review from a team as code owners August 1, 2023 18:13
@kweinmeister kweinmeister added actions:force-run kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed actions:force-run labels Aug 2, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 2, 2023
Copy link
Contributor

@telpirion telpirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sample requires an integration test:
https://googlecloudplatform.github.io/samples-style-guide/#testing

There are some stylistic differences in this sample from the norm. I suggest that you look at the following examples:

document-warehouse/delete-document-schema.js Outdated Show resolved Hide resolved
document-warehouse/delete-document-schema.js Outdated Show resolved Hide resolved
document-warehouse/delete-document-schema.js Outdated Show resolved Hide resolved
document-warehouse/delete-document-schema.js Outdated Show resolved Hide resolved
document-warehouse/delete-document-schema.js Outdated Show resolved Hide resolved
document-warehouse/delete-document-schema.js Outdated Show resolved Hide resolved
document-warehouse/delete-document-schema.js Outdated Show resolved Hide resolved
@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 8, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 8, 2023
@paulinawins paulinawins requested a review from telpirion August 9, 2023 02:44
@paulinawins paulinawins requested a review from a team as a code owner August 9, 2023 16:51
Copy link
Contributor Author

@paulinawins paulinawins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please review and approve when you have the time.
@telpirion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions:force-run samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants