-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
needs to new koa const for koa v 2 to work #351
Conversation
I was just reading through your tutorial in the Google App Engine kao intro and ran into Koa v2 requiring the "new" statement. Just wanted to give you the info to help out on the documentation. This doesn't look like the same code as in the example but maybe the message will reach you and I can sleep tonight knowing I helped fix something today :D
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@@ -17,6 +17,7 @@ | |||
|
|||
// [START server] | |||
const app = require('koa')(); | |||
const app = new koa(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to replace the line above it?
@emcwilliams Thanks for the PR! Do you want to make the requested changes? |
🤖 I have created a release *beep* *boop* --- ## [3.1.3](https://github.com/googleapis/nodejs-game-servers/compare/v3.1.2...v3.1.3) (2022-11-10) ### Bug Fixes * **deps:** Use google-gax v3.5.2 ([#349](https://github.com/googleapis/nodejs-game-servers/issues/349)) ([879eea3](https://github.com/googleapis/nodejs-game-servers/commit/879eea37422f58286d3e39e27f5c1b2f6aa4ae9c)) * Regenerated protos JS and TS definitions ([#353](https://github.com/googleapis/nodejs-game-servers/issues/353)) ([21535e1](https://github.com/googleapis/nodejs-game-servers/commit/21535e16d9dc28888514414117e463271383a971)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [3.1.3](https://github.com/googleapis/nodejs-game-servers/compare/v3.1.2...v3.1.3) (2022-11-10) ### Bug Fixes * **deps:** Use google-gax v3.5.2 ([#349](https://github.com/googleapis/nodejs-game-servers/issues/349)) ([879eea3](https://github.com/googleapis/nodejs-game-servers/commit/879eea37422f58286d3e39e27f5c1b2f6aa4ae9c)) * Regenerated protos JS and TS definitions ([#353](https://github.com/googleapis/nodejs-game-servers/issues/353)) ([21535e1](https://github.com/googleapis/nodejs-game-servers/commit/21535e16d9dc28888514414117e463271383a971)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
* updated CHANGELOG.md * updated package.json * updated samples/package.json
* updated CHANGELOG.md * updated package.json * updated samples/package.json
* updated CHANGELOG.md * updated package.json * updated samples/package.json
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
I was just reading through your tutorial in the Google App Engine kao intro and ran into Koa v2 requiring the "new" statement. Just wanted to give you the info to help out on the documentation. This doesn't look like the same code as in the example but maybe the message will reach you and I can sleep tonight knowing I helped fix something today :D