Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uploaded/updated logic for Cloud Storage #400

Merged
merged 3 commits into from
Jun 16, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion functions/helloworld/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ exports.helloGCS = function (event, callback) {

if (file.resourceState === 'not_exists') {
console.log(`File ${file.name} deleted.`);
} else if (file.metageneration === 1) {
} else if (file.metageneration === '1') {
// metageneration attribute is updated on metadata changes.
// on create value is 1
console.log(`File ${file.name} uploaded.`);
Expand Down
4 changes: 2 additions & 2 deletions functions/helloworld/test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ test.serial(`helloGCS: should print uploaded message`, (t) => {
data: {
name: `foo`,
resourceState: `exists`,
metageneration: 1
metageneration: `1`
}
}, callback);

Expand All @@ -161,7 +161,7 @@ test.serial(`helloGCS: should print metadata updated message`, (t) => {
data: {
name: `foo`,
resourceState: `exists`,
metageneration: 2
metageneration: `2`
}
}, callback);

Expand Down