Stackdriver samples #407
Merged
Stackdriver samples #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ace-n
reviewed
Jun 22, 2017
logging/logs.js
Outdated
| }); | ||
| console.log('Logs:'); | ||
| entries.forEach((entry) => { | ||
| console.log(entry.metadata[entry.metadata.payload]); |
There was a problem hiding this comment.
Nit: I take it there's no cleaner way to do this than referring to entry.metadata twice?
logging/logs.js
Outdated
|
|
||
| console.log('Logs:'); | ||
| entries.forEach((entry) => { | ||
| console.log(entry.metadata[entry.metadata.payload]); |
logging/system-test/logs.test.js
Outdated
|
|
||
| const logName = `nodejs-docs-samples-test-${uuid.v4()}`; | ||
| const projectId = process.env.GCLOUD_PROJECT; | ||
| const filter = `resource.type="global" AND logName="projects/${projectId}/logs/${logName}"`; | ||
| // const projectId = process.env.GCLOUD_PROJECT; |
There was a problem hiding this comment.
I take it these are supposed to be commented out? (not deleted, or uncommented)
logging/system-test/sinks.test.js
Outdated
| }); | ||
| }); | ||
| test.serial(`should update a sink`, async (t) => { | ||
| const output = await tools.runAsync(`${cmd} update ${sinkName} "severity >= WARNING"`, cwd); |
There was a problem hiding this comment.
Nit: should severity=WARNING be a constant here?
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 8, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 9, 2022
* chore(main): release 4.0.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 10, 2022
This was referenced Nov 11, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 15, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 15, 2022
telpirion
pushed a commit
that referenced
this pull request
Nov 16, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 17, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty simple, just updates some of the Stackdriver samples.