Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove basePath: "/" #588

Merged
merged 2 commits into from
Apr 6, 2018
Merged

Remove basePath: "/" #588

merged 2 commits into from
Apr 6, 2018

Commits on Mar 29, 2018

  1. Remove basePath: "/"

    I'm updating all the openapi files in the getting-started sample in all the sample repos to remove basePath: "/"
    Here's the reason from simonz130:
    
    From the OpenAPI 2 spec:
    * basePath: "If it is not included, the API is served directly under the host. The value MUST start with a leading slash (/). "
    * Paths for methods: "A relative path to an individual endpoint. The field name MUST begin with a slash. The path is appended to the basePath in order to construct the full URL."
    
    This OpenAPI getting-started sample have basePath: "/", which (per strict spec interpretation) means all the paths start with double-slashes. (e.g "//v1/shelves" rather than "/v1/shelves"). Removing basepath="/" fixes that.
    navinger authored Mar 29, 2018
    Configuration menu
    Copy the full SHA
    6197340 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2018

  1. Merge branch 'master' into patch-5

    Ace Nassri authored Mar 30, 2018
    Configuration menu
    Copy the full SHA
    6047b3c View commit details
    Browse the repository at this point in the history