Updated openapi.yaml security definition #602

diiiego83 · 2018-04-12T13:57:51Z

updated deprecated field in the security definition.
x-[key] to x-google-[key].

updated deprecated field in the security definition. x-[key] to x-google-[kye].

googlebot · 2018-04-12T13:57:54Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

diiiego83 · 2018-04-12T14:00:24Z

I signed it!

googlebot · 2018-04-12T14:00:29Z

CLAs look good, thanks!

simonz130 · 2018-06-05T20:19:31Z

appengine/endpoints/openapi.yaml

@@ -92,15 +92,15 @@ securityDefinitions:
    flow: "implicit"
    type: "oauth2"
    # This must match the 'iss' field in the JWT.
-    x-issuer: "jwt-client.endpoints.sample.google.com"
+    x-google-issuer: "jwt-client.endpoints.sample.google.com"


Thanks for fixing it!

codecov · 2018-06-06T00:50:32Z

Codecov Report

Merging #602 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #602   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f91c996...2207f36. Read the comment docs.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [uuid](https://togithub.com/uuidjs/uuid) | dependencies | major | [`^3.3.2` -> `^8.0.0`](https://renovatebot.com/diffs/npm/uuid/3.4.0/8.0.0) | --- ### Release Notes <details> <summary>uuidjs/uuid</summary> ### [`v8.0.0`](https://togithub.com/uuidjs/uuid/blob/master/CHANGELOG.md#800-httpsgithubcomuuidjsuuidcomparev703v800-2020-04-29) [Compare Source](https://togithub.com/uuidjs/uuid/compare/v7.0.3...v8.0.0) ##### ⚠ BREAKING CHANGES - For native ECMAScript Module (ESM) usage in Node.js only named exports are exposed, there is no more default export. ```diff -import uuid from 'uuid'; -console.log(uuid.v4()); // -> 'cd6c3b08-0adc-4f4b-a6ef-36087a1c9869' +import { v4 as uuidv4 } from 'uuid'; +uuidv4(); // ⇨ '9b1deb4d-3b7d-4bad-9bdd-2b0d7b3dcb6d' ``` - Deep requiring specific algorithms of this library like `require('uuid/v4')`, which has been deprecated in `uuid@7`, is no longer supported. Instead use the named exports that this module exports. For ECMAScript Modules (ESM): ```diff -import uuidv4 from 'uuid/v4'; +import { v4 as uuidv4 } from 'uuid'; uuidv4(); ``` For CommonJS: ```diff -const uuidv4 = require('uuid/v4'); +const { v4: uuidv4 } = require('uuid'); uuidv4(); ``` ##### Features - native Node.js ES Modules (wrapper approach) ([#423](https://togithub.com/uuidjs/uuid/issues/423)) ([2d9f590](https://togithub.com/uuidjs/uuid/commit/2d9f590ad9701d692625c07ed62f0a0f91227991)), closes [#245](https://togithub.com/uuidjs/uuid/issues/245) [#419](https://togithub.com/uuidjs/uuid/issues/419) [#342](https://togithub.com/uuidjs/uuid/issues/342) - remove deep requires ([#426](https://togithub.com/uuidjs/uuid/issues/426)) ([daf72b8](https://togithub.com/uuidjs/uuid/commit/daf72b84ceb20272a81bb5fbddb05dd95922cbba)) ##### Bug Fixes - add CommonJS syntax example to README quickstart section ([#417](https://togithub.com/uuidjs/uuid/issues/417)) ([e0ec840](https://togithub.com/uuidjs/uuid/commit/e0ec8402c7ad44b7ef0453036c612f5db513fda0)) ##### [7.0.3](https://togithub.com/uuidjs/uuid/compare/v7.0.2...v7.0.3) (2020-03-31) ##### Bug Fixes - make deep require deprecation warning work in browsers ([#409](https://togithub.com/uuidjs/uuid/issues/409)) ([4b71107](https://togithub.com/uuidjs/uuid/commit/4b71107d8c0d2ef56861ede6403fc9dc35a1e6bf)), closes [#408](https://togithub.com/uuidjs/uuid/issues/408) ##### [7.0.2](https://togithub.com/uuidjs/uuid/compare/v7.0.1...v7.0.2) (2020-03-04) ##### Bug Fixes - make access to msCrypto consistent ([#393](https://togithub.com/uuidjs/uuid/issues/393)) ([8bf2a20](https://togithub.com/uuidjs/uuid/commit/8bf2a20f3565df743da7215eebdbada9d2df118c)) - simplify link in deprecation warning ([#391](https://togithub.com/uuidjs/uuid/issues/391)) ([bb2c8e4](https://togithub.com/uuidjs/uuid/commit/bb2c8e4e9f4c5f9c1eaaf3ea59710c633cd90cb7)) - update links to match content in readme ([#386](https://togithub.com/uuidjs/uuid/issues/386)) ([44f2f86](https://togithub.com/uuidjs/uuid/commit/44f2f86e9d2bbf14ee5f0f00f72a3db1292666d4)) ##### [7.0.1](https://togithub.com/uuidjs/uuid/compare/v7.0.0...v7.0.1) (2020-02-25) ##### Bug Fixes - clean up esm builds for node and browser ([#383](https://togithub.com/uuidjs/uuid/issues/383)) ([59e6a49](https://togithub.com/uuidjs/uuid/commit/59e6a49e7ce7b3e8fb0f3ee52b9daae72af467dc)) - provide browser versions independent from module system ([#380](https://togithub.com/uuidjs/uuid/issues/380)) ([4344a22](https://togithub.com/uuidjs/uuid/commit/4344a22e7aed33be8627eeaaf05360f256a21753)), closes [#378](https://togithub.com/uuidjs/uuid/issues/378) ### [`v7.0.3`](https://togithub.com/uuidjs/uuid/blob/master/CHANGELOG.md#703-httpsgithubcomuuidjsuuidcomparev702v703-2020-03-31) [Compare Source](https://togithub.com/uuidjs/uuid/compare/v7.0.2...v7.0.3) ### [`v7.0.2`](https://togithub.com/uuidjs/uuid/blob/master/CHANGELOG.md#702-httpsgithubcomuuidjsuuidcomparev701v702-2020-03-04) [Compare Source](https://togithub.com/uuidjs/uuid/compare/v7.0.1...v7.0.2) ### [`v7.0.1`](https://togithub.com/uuidjs/uuid/blob/master/CHANGELOG.md#701-httpsgithubcomuuidjsuuidcomparev700v701-2020-02-25) [Compare Source](https://togithub.com/uuidjs/uuid/compare/v7.0.0...v7.0.1) ### [`v7.0.0`](https://togithub.com/uuidjs/uuid/blob/master/CHANGELOG.md#700-httpsgithubcomuuidjsuuidcomparev340v700-2020-02-24) [Compare Source](https://togithub.com/uuidjs/uuid/compare/v3.4.0...v7.0.0) ##### ⚠ BREAKING CHANGES - The default export, which used to be the v4() method but which was already discouraged in v3.x of this library, has been removed. - Explicitly note that deep imports of the different uuid version functions are deprecated and no longer encouraged and that ECMAScript module named imports should be used instead. Emit a deprecation warning for people who deep-require the different algorithm variants. - Remove builtin support for insecure random number generators in the browser. Users who want that will have to supply their own random number generator function. - Remove support for generating v3 and v5 UUIDs in Node.js<4.x - Convert code base to ECMAScript Modules (ESM) and release CommonJS build for node and ESM build for browser bundlers. ##### Features - add UMD build to npm package ([#357](https://togithub.com/uuidjs/uuid/issues/357)) ([4e75adf](https://togithub.com/uuidjs/uuid/commit/4e75adf435196f28e3fbbe0185d654b5ded7ca2c)), closes [#345](https://togithub.com/uuidjs/uuid/issues/345) - add various es module and CommonJS examples ([b238510](https://togithub.com/uuidjs/uuid/commit/b238510bf352463521f74bab175a3af9b7a42555)) - ensure that docs are up-to-date in CI ([ee5e77d](https://togithub.com/uuidjs/uuid/commit/ee5e77db547474f5a8f23d6c857a6d399209986b)) - hybrid CommonJS & ECMAScript modules build ([a3f078f](https://togithub.com/uuidjs/uuid/commit/a3f078faa0baff69ab41aed08e041f8f9c8993d0)) - remove insecure fallback random number generator ([3a5842b](https://togithub.com/uuidjs/uuid/commit/3a5842b141a6e5de0ae338f391661e6b84b167c9)), closes [#173](https://togithub.com/uuidjs/uuid/issues/173) - remove support for pre Node.js v4 Buffer API ([#356](https://togithub.com/uuidjs/uuid/issues/356)) ([b59b5c5](https://togithub.com/uuidjs/uuid/commit/b59b5c5ecad271c5453f1a156f011671f6d35627)) - rename repository to github:uuidjs/uuid ([#351](https://togithub.com/uuidjs/uuid/issues/351)) ([c37a518](https://togithub.com/uuidjs/uuid/commit/c37a518e367ac4b6d0aa62dba1bc6ce9e85020f7)), closes [#338](https://togithub.com/uuidjs/uuid/issues/338) ##### Bug Fixes - add deep-require proxies for local testing and adjust tests ([#365](https://togithub.com/uuidjs/uuid/issues/365)) ([7fedc79](https://togithub.com/uuidjs/uuid/commit/7fedc79ac8fda4bfd1c566c7f05ef4ac13b2db48)) - add note about removal of default export ([#372](https://togithub.com/uuidjs/uuid/issues/372)) ([12749b7](https://togithub.com/uuidjs/uuid/commit/12749b700eb49db8a9759fd306d8be05dbfbd58c)), closes [#370](https://togithub.com/uuidjs/uuid/issues/370) - deprecated deep requiring of the different algorithm versions ([#361](https://togithub.com/uuidjs/uuid/issues/361)) ([c0bdf15](https://togithub.com/uuidjs/uuid/commit/c0bdf15e417639b1aeb0b247b2fb11f7a0a26b23)) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-dialogflow).

Updated openapi.yaml security definition

851d726

updated deprecated field in the security definition. x-[key] to x-google-[kye].

simonz130 reviewed Jun 5, 2018

View reviewed changes

simonz130 approved these changes Jun 5, 2018

View reviewed changes

Merge branch 'master' into patch-1

f45224a

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 6, 2018

JustinBeckwith added 5 commits June 6, 2018 15:02

Merge branch 'master' into patch-1

b792d37

Merge branch 'master' into patch-1

7081682

Merge branch 'master' into patch-1

28ce39e

Merge branch 'master' into patch-1

078a7d2

Merge branch 'master' into patch-1

2207f36

JustinBeckwith merged commit dfe30b9 into GoogleCloudPlatform:master Jun 14, 2018

snyk-bot mentioned this pull request Aug 27, 2020

[Snyk] Fix for 1 vulnerabilities pedroarapua/nodejs-docs-samples-gcp#132

Open

This was referenced Sep 3, 2020

[Snyk] Fix for 1 vulnerabilities pedroarapua/nodejs-docs-samples-gcp#169

Open

[Snyk] Fix for 1 vulnerabilities leejh3224/nodejs-docs-samples#248

Open

snyk-bot mentioned this pull request Sep 2, 2021

[Snyk] Security upgrade @google-cloud/pubsub from 0.22.2 to 0.29.0 leejh3224/nodejs-docs-samples#340

Open

This was referenced Jan 11, 2022

[Snyk] Fix for 2 vulnerabilities leejh3224/nodejs-docs-samples#409

Open

[Snyk] Fix for 2 vulnerabilities pedroarapua/nodejs-docs-samples-gcp#309

Open

This was referenced Mar 21, 2022

[Snyk] Fix for 3 vulnerabilities leejh3224/nodejs-docs-samples#496

Open

[Snyk] Fix for 3 vulnerabilities pedroarapua/nodejs-docs-samples-gcp#323

Open

ahrarmonsur mentioned this pull request Nov 18, 2022

migrate code from googleapis/nodejs-dialogflow #2873

Merged

pedroarapua mentioned this pull request Nov 30, 2023

[Snyk] Security upgrade @google-cloud/pubsub from 0.28.1 to 0.29.0 pedroarapua/nodejs-docs-samples-gcp#478

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated openapi.yaml security definition #602

Updated openapi.yaml security definition #602

diiiego83 commented Apr 12, 2018

googlebot commented Apr 12, 2018

diiiego83 commented Apr 12, 2018

googlebot commented Apr 12, 2018

simonz130 Jun 5, 2018

codecov bot commented Jun 6, 2018 •

edited

Loading

Updated openapi.yaml security definition #602

Updated openapi.yaml security definition #602

Conversation

diiiego83 commented Apr 12, 2018

googlebot commented Apr 12, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

diiiego83 commented Apr 12, 2018

googlebot commented Apr 12, 2018

simonz130 Jun 5, 2018

Choose a reason for hiding this comment

codecov bot commented Jun 6, 2018 • edited Loading

Codecov Report

codecov bot commented Jun 6, 2018 •

edited

Loading