Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a bug introduced by pug 2.0.0. #608

Merged
merged 2 commits into from
May 4, 2018
Merged

Fixed a bug introduced by pug 2.0.0. #608

merged 2 commits into from
May 4, 2018

Conversation

michaelawyu
Copy link
Contributor

See #607 for more information.

Fixed a bug introduced by pug 2.0.0.
77fed8c 
See #607 for more information.
@michaelawyu michaelawyu requested a review from ace-n April 28, 2018 02:48
@codecov
Copy link

codecov bot commented Apr 28, 2018 •
edited
Loading

Codecov Report

Merging #608 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #608   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d9b39...c2bc6a7. Read the comment docs.

ace-n
ace-n approved these changes Apr 30, 2018
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming tests pass

@JustinBeckwith JustinBeckwith merged commit c67d955 into master May 4, 2018
@michaelawyu michaelawyu deleted the michaelawyu-patch-1 branch May 23, 2018 01:00
@snyk-bot snyk-bot mentioned this pull request Aug 27, 2020
Open
This was referenced Sep 3, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 2, 2021
Open
This was referenced Jan 11, 2022
Open
Open
This was referenced Mar 21, 2022
Open
Open
NimJay pushed a commit that referenced this pull request Nov 10, 2022
@release-please
chore: release 4.2.9 (#609)
ac40f37 
🤖 I have created a release \*beep\* \*boop\*
---
### [4.2.9](https://www.github.com/googleapis/nodejs-language/compare/v4.2.8...v4.2.9) (2021-08-17)


### Bug Fixes

* **deps:** google-gax v2.24.1 ([#608](https://www.github.com/googleapis/nodejs-language/issues/608)) ([81d9fa1](https://www.github.com/googleapis/nodejs-language/commit/81d9fa1ff73ea6129d85bcf071cadd3946b9bdd7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
NimJay pushed a commit that referenced this pull request Nov 10, 2022
@release-please @NimJay
chore: release 4.2.9 (#609)
4307147 
🤖 I have created a release \*beep\* \*boop\*
---
### [4.2.9](https://www.github.com/googleapis/nodejs-language/compare/v4.2.8...v4.2.9) (2021-08-17)


### Bug Fixes

* **deps:** google-gax v2.24.1 ([#608](https://www.github.com/googleapis/nodejs-language/issues/608)) ([81d9fa1](https://www.github.com/googleapis/nodejs-language/commit/81d9fa1ff73ea6129d85bcf071cadd3946b9bdd7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 14, 2022
@FrodoTheTrue @bcoe
chore(samples): remove default rest and compute_protos (#608)
7fe2c45 
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
This was referenced Nov 14, 2022
Closed
Merged
ace-n pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore: release 3.4.0 (#616)
a0ab434 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.4.0](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.3.6...v3.4.0) (2021-09-15)


### Features

* turns on self-signed JWT feature flag ([#608](https://www.github.com/googleapis/nodejs-video-intelligence/issues/608)) ([a08a54b](https://www.github.com/googleapis/nodejs-video-intelligence/commit/a08a54b3c49464ca5b8df8ba924d244ab61665ba))


### Bug Fixes

* **build:** migrate to using main branch ([#613](https://www.github.com/googleapis/nodejs-video-intelligence/issues/613)) ([68e079f](https://www.github.com/googleapis/nodejs-video-intelligence/commit/68e079f1d985d60576342663a2008d316502e205))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore: release 3.4.0 (#616)
159362c 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.4.0](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.3.6...v3.4.0) (2021-09-15)


### Features

* turns on self-signed JWT feature flag ([#608](https://www.github.com/googleapis/nodejs-video-intelligence/issues/608)) ([a08a54b](https://www.github.com/googleapis/nodejs-video-intelligence/commit/a08a54b3c49464ca5b8df8ba924d244ab61665ba))


### Bug Fixes

* **build:** migrate to using main branch ([#613](https://www.github.com/googleapis/nodejs-video-intelligence/issues/613)) ([68e079f](https://www.github.com/googleapis/nodejs-video-intelligence/commit/68e079f1d985d60576342663a2008d316502e205))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
@release-please @ahrarmonsur
chore: release 3.4.0 (#616)
621a472 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.4.0](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.3.6...v3.4.0) (2021-09-15)


### Features

* turns on self-signed JWT feature flag ([#608](https://www.github.com/googleapis/nodejs-video-intelligence/issues/608)) ([a08a54b](https://www.github.com/googleapis/nodejs-video-intelligence/commit/a08a54b3c49464ca5b8df8ba924d244ab61665ba))


### Bug Fixes

* **build:** migrate to using main branch ([#613](https://www.github.com/googleapis/nodejs-video-intelligence/issues/613)) ([68e079f](https://www.github.com/googleapis/nodejs-video-intelligence/commit/68e079f1d985d60576342663a2008d316502e205))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 21, 2022
@FrodoTheTrue @bcoe
chore(samples): remove default rest and compute_protos (#608)
429b53f 
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
ace-n pushed a commit that referenced this pull request Nov 21, 2022
@FrodoTheTrue @bcoe
chore(samples): remove default rest and compute_protos (#608)
bbf3c5c 
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
This was referenced Nov 28, 2023
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelawyu @ace-n @JustinBeckwith