Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify build script #666

Merged
merged 2 commits into from
Jun 18, 2018
Merged

Simplify build script #666

merged 2 commits into from
Jun 18, 2018

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Jun 18, 2018

Use a shorter version string.

Do not check for worker.yaml, as no sample has one.

Do not check for worker.yaml, none of the examples have one.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2018


# Test the deployed app
# Install dependencies and run tests
npm install
npm test

exit $?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the node packages care about ending newlines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not.

@fhinkel fhinkel merged commit a42e9c1 into master Jun 18, 2018
@fhinkel fhinkel deleted the simplifyBuildScript branch June 18, 2018 20:51
NimJay pushed a commit that referenced this pull request Nov 10, 2022
* build!: Update library to use Node 12
NimJay pushed a commit that referenced this pull request Nov 10, 2022
* build!: Update library to use Node 12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants