Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify mocking comments #682

Merged
merged 2 commits into from
Jul 21, 2018
Merged

Clarify mocking comments #682

merged 2 commits into from
Jul 21, 2018

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Jul 6, 2018

No description provided.

@ace-n ace-n requested a review from jmdobry July 6, 2018 20:22
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 6, 2018
@codecov
Copy link

codecov bot commented Jul 6, 2018 •
edited
Loading

Codecov Report

Merging #682 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #682   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04340fc...da6a9f2. Read the comment docs.

@ace-n ace-n added the GCF Docs label Jul 12, 2018
@ace-n ace-n merged commit ed0db75 into master Jul 21, 2018
@ace-n ace-n deleted the mock-comments branch July 21, 2018 00:05
ace-n pushed a commit that referenced this pull request Jul 23, 2018
Make logging sample an HTTP function (#691)
1453f75 
* Update index.js

* Clarify mocking comments (#682)

* fix: just adding : for log consistency (#694)

* Update index.js

* Update index.js

* Update index.js

* Fix test
This was referenced Jul 6, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

@jmdobry jmdobry Awaiting requested review from jmdobry

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ace-n @andrewsg @googlebot