Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial import for tutorial for handling sessions #332

Merged
merged 2 commits into from
Aug 5, 2019
Merged

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Aug 1, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2019
@fhinkel fhinkel force-pushed the sessions branch 2 times, most recently from 1e0a74e to 4ff5b5f Compare August 1, 2019 17:37
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 1, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 1, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 1, 2019
@fhinkel fhinkel requested a review from tbpg August 5, 2019 13:45
sessions/index.js Show resolved Hide resolved
sessions/package.json Outdated Show resolved Hide resolved
sessions/package.json Outdated Show resolved Hide resolved
const session = require('express-session');
const app = express();

const {FirestoreStore} = require('@google-cloud/connect-firestore');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meta question - why put the sample here, and not in the https://github.com/googleapis/nodejs-firestore-session/ repo?

Copy link
Contributor Author

@fhinkel fhinkel Aug 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's part of the Getting-Started experience rather than firestore-connect. We're showing how to use multiple products together.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to be honest, thought I was looking at the nodejs-docs-samples repo when I wrote that 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants