Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background tutorial #338

Merged
merged 4 commits into from
Sep 18, 2019
Merged

Add background tutorial #338

merged 4 commits into from
Sep 18, 2019

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Sep 13, 2019

Add code for background processing with PubSub and Firestore.

Drive-by fix: clean up package.json files.

Tests are failing as we're still testing the old bookshelf config on the wrong branch.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 13, 2019
@fhinkel fhinkel added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 13, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 13, 2019
@fhinkel fhinkel removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 18, 2019
@fhinkel fhinkel requested a review from tbpg September 18, 2019 02:38
Delete unnecessary dependencies

Implement translate.js

Update html template with handlebars

Move lint dependencies to top level

Split background into two directories

Clean up package.json files

Add top level package.json for linting all tutorials
Copy link

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@@ -3,7 +3,7 @@
"description": "Minimal app to use authentication information from IAP.",
"private": true,
"license": "Apache-2.0",
"author": "Google LLC",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think LLC is right? Not sure at all - going off of the license header.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going with what we have in the auto generated Node.js libraries. Let me check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing to LLC, thanks for noticing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants