-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add background tutorial #338
Conversation
Delete unnecessary dependencies Implement translate.js Update html template with handlebars Move lint dependencies to top level Split background into two directories Clean up package.json files Add top level package.json for linting all tutorials
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
authenticating-users/package.json
Outdated
@@ -3,7 +3,7 @@ | |||
"description": "Minimal app to use authentication information from IAP.", | |||
"private": true, | |||
"license": "Apache-2.0", | |||
"author": "Google LLC", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think LLC is right? Not sure at all - going off of the license header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going with what we have in the auto generated Node.js libraries. Let me check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing to LLC, thanks for noticing.
Add code for background processing with PubSub and Firestore.
Drive-by fix: clean up
package.json
files.Tests are failing as we're still testing the old bookshelf config on the wrong branch.