Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add presubmit task for linting #346

Merged
merged 2 commits into from
Sep 19, 2019
Merged

Add presubmit task for linting #346

merged 2 commits into from
Sep 19, 2019

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Sep 19, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 19, 2019
@fhinkel fhinkel requested a review from bcoe September 19, 2019 01:28
bcoe
bcoe approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me; I assume npm test is handled by another kokoro task?

@fhinkel
Copy link
Contributor Author

fhinkel commented Sep 19, 2019

I'll need to add more tests. I was hoping you can help with that. You have tooling to generate those configs, right?

@fhinkel fhinkel merged commit 43abcee into master Sep 19, 2019
@fhinkel fhinkel deleted the linter branch September 19, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhinkel @bcoe @googlebot