Skip to content

Commit

Permalink
rename untyped featuregate to comply with feature gate character set …
Browse files Browse the repository at this point in the history
…restrictions
  • Loading branch information
dashpole committed Nov 13, 2023
1 parent 0b578e8 commit 89308cd
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const (
// prometheus metric. Internal use only.
GCPOpsAgentUntypedMetricKey = "prometheus.googleapis.com/internal/untyped_metric"

gcpUntypedDoubleExportGateKey = "gcp.untyped_double_export"
gcpUntypedDoubleExportGateKey = "gcp.untypedDoubleDxport"
)

var untypedDoubleExportFeatureGate = featuregate.GlobalRegistry().MustRegister(
Expand Down
2 changes: 1 addition & 1 deletion exporter/collector/googlemanagedprometheus/naming_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ func TestGetMetricName(t *testing.T) {
expected: "bar/gauge",
},
{
desc: "untyped sum with gcp.untyped_double_export disabled only normalizes",
desc: "untyped sum with gcp.untypedDoubleExport disabled only normalizes",
baseName: "bar",
metric: func(m pmetric.Metric) {
//nolint:errcheck
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ var MetricsTestCases = []TestCase{
ConfigureCollector: func(cfg *collector.Config) {
configureGMPCollector(cfg)
//nolint:errcheck
featuregate.GlobalRegistry().Set("gcp.untyped_double_export", true)
featuregate.GlobalRegistry().Set("gcp.untypedDoubleExport", true)
},
// prometheus_target is not supported by the SDK
SkipForSDK: true,
Expand Down

0 comments on commit 89308cd

Please sign in to comment.