fix: flatten ValueTypeSlice to ValueTypeString (#831)

* fix: flatten ValueTypeSlice to ValueTypeString * fix: use json marshalling for non-primitive values * fix: validate returned errors in tests Co-authored-by: David Ashpole <dashpole@google.com> Signed-off-by: Keaton Cross <keatoncross6@gmail.com> * fix: regenerate test fixtures --------- Signed-off-by: Keaton Cross <keatoncross6@gmail.com> Co-authored-by: David Ashpole <dashpole@google.com>
GoogleCloudPlatform · Apr 23, 2024 · fd38e34 · fd38e34
1 parent aca1cfd
commit fd38e34
Show file tree

Hide file tree

Showing 4 changed files with 212 additions and 0 deletions.
diff --git a/exporter/collector/integrationtest/testdata/fixtures/traces/traces_basic_expected.json b/exporter/collector/integrationtest/testdata/fixtures/traces/traces_basic_expected.json
@@ -119,6 +119,11 @@
                   "value": "semver:0.33.0"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -298,6 +303,11 @@
                   "value": "semver:0.33.0"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -477,6 +487,11 @@
                   "value": "semver:0.33.0"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -656,6 +671,11 @@
                   "value": "semver:0.33.0"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -786,6 +806,11 @@
                   "value": "go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -911,6 +936,11 @@
                   "value": "go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -1036,6 +1066,11 @@
                   "value": "go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -1161,6 +1196,11 @@
                   "value": "go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -1257,6 +1297,11 @@
                   "value": "demo-client-tracer"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -1353,6 +1398,11 @@
                   "value": "demo-client-tracer"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -1449,6 +1499,11 @@
                   "value": "demo-client-tracer"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -1545,6 +1600,11 @@
                   "value": "demo-client-tracer"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -1719,6 +1779,11 @@
                   "value": "semver:0.33.0"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -1898,6 +1963,11 @@
                   "value": "semver:0.33.0"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -2077,6 +2147,11 @@
                   "value": "semver:0.33.0"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -2212,6 +2287,11 @@
                   "value": "semver:0.33.0"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -2342,6 +2422,11 @@
                   "value": "semver:0.33.0"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -2472,6 +2557,11 @@
                   "value": "semver:0.33.0"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -2602,6 +2692,11 @@
                   "value": "semver:0.33.0"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"
@@ -2698,6 +2793,11 @@
                   "value": "demo-client-tracer"
                 }
               },
+              "process.command_args": {
+                "stringValue": {
+                  "value": "[\"./main\"]"
+                }
+              },
               "process.executable.name": {
                 "stringValue": {
                   "value": "main"