Write logs to gae_app instead of gae_instance #702
Merged
+141
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #702 +/- ##
==========================================
- Coverage 69.59% 69.56% -0.04%
==========================================
Files 36 36
Lines 4717 4711 -6
==========================================
- Hits 3283 3277 -6
Misses 1286 1286
Partials 148 148
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dashpole
force-pushed
the
fix_gae_logging_mr
branch
from
cb516c5
to
518aad7
Compare
|
@aabmass can you take a look when you get the chance? |
|
Is this just one of those weird inconsistencies between Cloud Logging and Cloud Monitoring? |
aabmass
approved these changes
Aug 18, 2023
|
Yes. Cloud logging has a different MR for GAE than cloud monitoring does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #696
I also simplified MR mapping by moving returning a *monitoredrespb.MonitoredResource from the internal package, and performing utf-8 sanitization in the internal package.