Update metric example to use resource detectors #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
approved these changes
Sep 21, 2023
Co-authored-by: Aaron Abbott <aaronabbott@google.com>
Codecov Report
@@ Coverage Diff @@
## main #724 +/- ##
=======================================
Coverage 69.48% 69.48%
=======================================
Files 42 42
Lines 4847 4847
=======================================
Hits 3368 3368
Misses 1328 1328
Partials 151 151 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures users that run the example on GCP infrastructure get appropriate resource attributes. It also includes the resoruce.FromEnv option to ensure environment-variable-based resources are correctly detected.