Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update otel to the newest version #728

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Sep 27, 2023

Fixes #726

Updates opentelemetry-go's metric sdk from v0.41.0 to v1.19.0, which is the GA release of the metrics SDK. This includes a breaking change in the SDK which removed the go.opentelemetry.io/otel/sdk/metric/aggregation package. Trying to use the latest SDK version with the current latest version of this repository results in a compilation failure.

@dashpole dashpole requested a review from a team as a code owner September 27, 2023 19:23
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #728 (3314bdd) into main (4284c1c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #728   +/-   ##
=======================================
  Coverage   69.49%   69.49%           
=======================================
  Files          42       42           
  Lines        4845     4845           
=======================================
  Hits         3367     3367           
  Misses       1329     1329           
  Partials      149      149           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dashpole
Copy link
Contributor Author

@aabmass

@dashpole dashpole merged commit f894929 into GoogleCloudPlatform:main Sep 29, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import error sdk/metric/aggregation
2 participants