-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OTel dependencies for go workspaces #793
Conversation
This PR updates all OTel dependencies to the latest version to allow this repo to leverage go workspaces without the ambiguous import problem with `github.com/knadh/koanf`.
go run cmd/recordfixtures/main.go
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
==========================================
+ Coverage 69.94% 70.02% +0.08%
==========================================
Files 42 42
Lines 4877 4877
==========================================
+ Hits 3411 3415 +4
+ Misses 1315 1311 -4
Partials 151 151 ☔ View full report in Codecov by Sentry. |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any action required for developers to use go workspaces with this repo?
@dashpole they need to run |
This change allows for this repo to be used as part of a Go workspace. This is very useful in tandem with either `opentelemetry-operations-go` or `opentelemetry-collector-contrib` because it allows us to create a workspace with this collector and the library we want to test, add a manual replacement in the workspace for that dependency, and be able to test the collector with local copies of the dependency without changing anything. Related: GoogleCloudPlatform/opentelemetry-operations-go#793
Thanks for making the workspaces changes @braydonk, especially figuring out that I looked a little into workspaces and it sounds like |
This change allows for this repo to be used as part of a Go workspace. This is very useful in tandem with either `opentelemetry-operations-go` or `opentelemetry-collector-contrib` because it allows us to create a workspace with this collector and the library we want to test, add a manual replacement in the workspace for that dependency, and be able to test the collector with local copies of the dependency without changing anything. Related: GoogleCloudPlatform/opentelemetry-operations-go#793
This PR updates all OTel dependencies to the latest version to allow this repo to leverage go workspaces without the ambiguous import problem with
github.com/knadh/koanf
.To produce these changes I did the following:
go work init go work use -r . go mod edit -exclude=github.com/knadh/koanf@v1.5.0 go work sync
I then updated the OTel versions in the Makefile, and added a couple OTel dependencies that weren't listed in the
update-otel
target. Then ranmake update-otel
.I also added a new make target that will generate the Go module workspace.