Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC examples with OTLP SDK #800

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Feb 7, 2024

Uses our basic examples with gRPC application default credential functions to send OTLP

@damemi damemi requested a review from a team as a code owner February 7, 2024 18:06
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fda999e) 69.94% compared to head (13f76b5) 70.22%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #800      +/-   ##
==========================================
+ Coverage   69.94%   70.22%   +0.28%     
==========================================
  Files          42       42              
  Lines        4877     4886       +9     
==========================================
+ Hits         3411     3431      +20     
+ Misses       1315     1307       -8     
+ Partials      151      148       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damemi damemi force-pushed the auth-otlp-sample branch 2 times, most recently from 5c6256d to bb3eaac Compare February 7, 2024 18:20
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why the trace sample is in a client subdirectory, but the metric one isn't?

example/metric/otlpgrpc/example.go Show resolved Hide resolved
example/trace/otlpgrpc/client/client.go Outdated Show resolved Hide resolved
example/trace/otlpgrpc/client/client.go Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@damemi
Copy link
Contributor Author

damemi commented Feb 8, 2024

any reason why the trace sample is in a client subdirectory, but the metric one isn't?

It's not referring to the otlp client, it's 2 directories, client and server just copied from our existing example https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/tree/266b13738059ce0f18feef3e5b7e235c48d0065c/example/trace/http

edit: simplified it down to one file with a time.sleep

@damemi damemi merged commit 4cdbea2 into GoogleCloudPlatform:main Feb 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants