-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example/metric : Add exponential_histogram README and reorganize folders. #821
example/metric : Add exponential_histogram README and reorganize folders. #821
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
+ Coverage 60.00% 61.03% +1.02%
==========================================
Files 56 56
Lines 5896 5902 +6
==========================================
+ Hits 3538 3602 +64
+ Misses 2206 2143 -63
- Partials 152 157 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@franciscovalentecastro I see this is a draft but just curious, why move the existing examples into a new export
folder? Couldn't the exponential_histogram
example folder just go under the existing examples directory with them?
Re @damemi, I was writing a README.md for the
I don't have any strong opinion between options |
I'll let @damemi do this review |
@franciscovalentecastro ah I see. What if we add a new Then copy The only difference is the chart image, but you could add a small README to each example that just shows the final chart image. My reasoning behind this is that the |
@franciscovalentecastro could you please update the package in |
Re @damemi :
Thanks for the review and guidance. I agree with all comments. I addressed all requested changes.
Fixed. More Details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @franciscovalentecastro !
Closes #804