Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BMS machines to the resource detection library #828

Merged
merged 5 commits into from Apr 25, 2024
Merged

Add support for BMS machines to the resource detection library #828

merged 5 commits into from Apr 25, 2024

Conversation

ghost
Copy link

@ghost ghost commented Apr 5, 2024

This PR adds support for BMS machines to the resource detection library.

I'm planning to upgrade the resource detection processor within the opentelemetry-collector-contrib repository to make use of this new BMS detector, aiming to enable native BMS support in the otel collector.

Due to the absence of a metadata server in the BMS environment, we rely on the presence of BMS_PROJECT_ID, BMS_REGION, and BMS_INSTANCE_ID environment variables as an indication that the collector is running on BMS machines. Customers are expected to manually enter these variables into the Ops Agent's collector using the DefaultEnvironment parameter in the /etc/systemd/system.conf file.

@ghost ghost self-requested a review as a code owner April 5, 2024 17:22
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.57%. Comparing base (4caace7) to head (f33e99e).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
+ Coverage   61.03%   62.57%   +1.53%     
==========================================
  Files          56       57       +1     
  Lines        5903     4911     -992     
==========================================
- Hits         3603     3073     -530     
+ Misses       2143     1681     -462     
  Partials      157      157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

detectors/gcp/bms.go Outdated Show resolved Hide resolved
@dashpole dashpole merged commit 2160268 into GoogleCloudPlatform:main Apr 25, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants