Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exporter/collector: avoid using req.String() to check for empty request #889

Merged
merged 2 commits into from
Sep 12, 2024
Merged

exporter/collector: avoid using req.String() to check for empty request #889

merged 2 commits into from
Sep 12, 2024

Commits on Sep 12, 2024

  1. exporter/collector: avoid using req.String() to check for empty request 

    This change is motivated by some CPU profiling that showed that its
responsible for over 20% of CPU time in my environment (running
avalanche, OTel with Prom receiver and the gmp exporter). Sending this
change because its logically equivalent to before but avoids the
serialization to the string.
    @ridwanmsharif
    ridwanmsharif committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4b9f69b View commit details
    Browse the repository at this point in the history

  2. add micro benchmark test

    @ridwanmsharif
    ridwanmsharif committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    15099b9 View commit details
    Browse the repository at this point in the history