Fix bug where grpc self-observability metrics were not added #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
==========================================
+ Coverage 61.03% 63.66% +2.62%
==========================================
Files 56 57 +1
Lines 5903 6066 +163
==========================================
+ Hits 3603 3862 +259
+ Misses 2143 2042 -101
- Partials 157 162 +5 ☔ View full report in Codecov by Sentry. |
|
The integration test now exports self-observability metrics using our SDK exporter. I checked in the e2e test project to see that the metrics were present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #885, I only added grpc observability metrics when insecure = true. This passed our tests that use a local, fake grpc server, but didn't work for the general case.
It turns out that the metrics were actually coming from the client library, which enables opencensus metrics by default. After the OC bridge was removed, those metrics disappeared.
This PR adds grpc metrics for the non-insecure case.
TESTED=checked that the e2e test project contains grpc self-obs metrics