Add performance tuning notes to exporter readme #903
Merged
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
==========================================
+ Coverage 61.03% 63.60% +2.56%
==========================================
Files 56 57 +1
Lines 5903 6066 +163
==========================================
+ Hits 3603 3858 +255
+ Misses 2143 2046 -97
- Partials 157 162 +5 ☔ View full report in Codecov by Sentry. |
dashpole
reviewed
Oct 21, 2024
| @@ -297,6 +297,36 @@ underscores (eg, `service.name`), but these will still collide once all | |||
| attributes are normalized to metric labels. In this case you will need to update | |||
| the collector config above appropriately. | |||
|
|
|||
| ### Performance tuning | |||
There was a problem hiding this comment.
Are these numbers specific to trace?
|
I've been thinking we should remove the readme from this repo, and redirect to the upstream README to have a single source of truth. WDYT? |
dashpole
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds notes from #456 to the readme for performance tuning options.
Fixes #871