Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud Support Slackbot #673

Merged
merged 52 commits into from
Aug 14, 2021
Merged

Google Cloud Support Slackbot #673

merged 52 commits into from
Aug 14, 2021

Conversation

TheLanceLord
Copy link
Member

Description: Code for customers with Premium Support and access to the v2Alpha Cloud Support API to be able to deploy a Slack bot that regularly pulls support case information from Google Cloud and pushes it to Slack. Includes a python script, requirements file, images for the Slack icon .env template, and default template for nginx.

Bug: I checked for PSO Engineering Council but the moma page said it was paused. If there is a component where I should file a bug let me know and I'll be happy to submit one. Otherwise my manager nitameng@ can vouch for what has been built

Other: Also I encountered issues with pylint where it is trying to read the my Response object as a string, and it doesn't understand the concept of f"text". The code itself works and has been deployed with customer

@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines. label Aug 5, 2021
@google-cla google-cla bot added the cla: yes All committers have signed a CLA label Aug 5, 2021
Copy link
Member

@iht iht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline comments.

1. Under **Network interfaces**, click the network interface box
1. Set **Network** to the VPC where you have your firewall rules
1. Under **External IP**, select **Create IP address**. Choose whichever name and network service tier you prefer
1. Click **Create**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All setup above can be performed in Terraform or Google Cloud Resource Manager. Is there any guidelines for that repository when Terraform should be used and when plain text tutorial? See example https://github.com/GoogleCloudPlatform/professional-services/tree/main/examples/kerberized_data_lake .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the answer is it depends on each team's maturity with Google Cloud. For an organization that is new to cloud, following the step-by-step guide will likely make the most sense. For more experienced teams though, they will likely have terraform already handy that they can use to build up vanilla projects with most of this implemented

@TheLanceLord
Copy link
Member Author

Do you have vector file of that image to enable future contribution?

Added!

@TheLanceLord TheLanceLord requested a review from iht August 12, 2021 00:07
@TheLanceLord
Copy link
Member Author

TheLanceLord commented Aug 12, 2021

Here's a quick Trello board for tracking all the features to be added for v1, which should be in the next 3-6 months: https://trello.com/b/i8bPx6bQ/google-cloud-support-slackbot-v1

@ad-m
Copy link

ad-m commented Aug 12, 2021

Here's a quick Trello board for tracking all the features to be added for v1, which should be in the next 3-6 months

Could you provide that link again? I can not open that link, because I don't see any link.

@TheLanceLord
Copy link
Member Author

I edited it in to the comment above, let me know if there is anything missing!

Copy link
Member

@iht iht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


### VM

Go to **Compute Engine > VM instances** and perform the following:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can always deploy a new version of a Cloud Function (https://cloud.google.com/functions/docs/deploying#migrating_between_deployments), which, in a way, is an update of an existing function.

@iht
Copy link
Member

iht commented Aug 14, 2021

/gbcrun

@iht iht merged commit 2ae83e1 into GoogleCloudPlatform:main Aug 14, 2021
rosmo pushed a commit to rosmo/professional-services that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes All committers have signed a CLA size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants