Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(job): migrate region step 3 - remove regions in jobs/v3/api_client/base_job_sample.py #12977

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eapl-gemugami
Copy link
Contributor

Description

Fixes Internal:
b/347349725
b/347350189
b/347825769

Checklist

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: jobs Issues related to the Cloud Talent Solution Job Search API. labels Dec 9, 2024
@eapl-gemugami eapl-gemugami added the snippet-bot:force-run Force snippet-bot runs its logic label Dec 9, 2024
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Dec 9, 2024
Copy link

snippet-bot bot commented Dec 9, 2024

Here is the summary of possible violations 😱

There is a possible violation for removing region tag in use.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to delete 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@eapl-gemugami
Copy link
Contributor Author

The source code for document https://cloud.google.com/talent-solution/job-search/v3/docs/create-company-job was already fixed in cl/648955387 by yoshifumi.

Reviewer: Please take a look into that doc to check if setvar sample_id also needs to be changed from create_basic_job to job_create_job before merging this PR.
Rather than that I don't see any other usage of region_tag create_job as the snippet-box suggests.

@eapl-gemugami eapl-gemugami marked this pull request as ready for review December 19, 2024 16:43
@eapl-gemugami eapl-gemugami requested review from a team as code owners December 19, 2024 16:43
@iennae iennae added the snippet-bot:force-run Force snippet-bot runs its logic label Dec 19, 2024
@iennae iennae assigned iennae and unassigned kweinmeister Dec 19, 2024
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: jobs Issues related to the Cloud Talent Solution Job Search API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants