Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): Remove Beam version from requirements.txt file #13002

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VeronicaWasson
Copy link
Contributor

Description

This sample pinned the Beam SDK version number. However, the latest template base image always uses the latest Beam, so it's not needed and can cause errors;

More information: b/374216225

Checklist

@VeronicaWasson VeronicaWasson requested review from a team as code owners December 17, 2024 01:29
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi VeronicaWasson,

Gemini is currently reviewing this pull request and will provide a full review shortly. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request removes the pinned Beam SDK version from the requirements.txt file within the dataflow/flex-templates/getting_started directory. The intent, as stated in the description, is to resolve errors caused by pinning the Beam version when the latest template base image already uses the latest Beam version. The change involves a single line modification in dataflow/flex-templates/getting_started/requirements.txt, removing the specific version number and leaving only apache-beam[gcp]. This allows the build to use the latest available Beam SDK.

The change is straightforward and addresses a potential source of errors. The PR description also includes a reference to a related issue (b/374216225), which provides additional context.


Here's a little haiku to lighten the mood:

Version numbers gone,
Latest Beam now flows freely,
Errors fade away.

Thanks!
Gemini

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 17, 2024
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request removes the pinned Beam SDK version from the requirements.txt file. This is a good change as it avoids potential conflicts with the base image's Beam version and aligns with the recommended practice of using the latest Beam SDK. The PR description clearly explains the rationale for the change and references the related bug report. The checklist is mostly complete, but there's one minor point to address regarding the README.

dataflow/flex-templates/getting_started/requirements.txt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants