Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use new subscribe() syntax #1989

Merged
merged 8 commits into from
Feb 5, 2019
Merged

Update to use new subscribe() syntax #1989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
476a1e8
Update to use new subscribe() syntax
engelke Jan 31, 2019
7138a54
Missed two subscribe() call changes before
engelke Feb 1, 2019
96f9d1f
Cancel subscription when processed
engelke Feb 4, 2019
970a3ea
Cancel subscription when processed
engelke Feb 4, 2019
3c01802
Merge branch 'master' into engelke_dlp_fixes
engelke Feb 4, 2019
7621492
Update risk.py
engelke Feb 4, 2019
e1fc466
Fix waiting for message
engelke Feb 4, 2019
9e1cdd2
Unneeded try/except removed
engelke Feb 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions dlp/jobs_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@


@pytest.fixture(scope='session')
def create_test_job():
def test_job_name():
import google.cloud.dlp
dlp = google.cloud.dlp.DlpServiceClient()

Expand Down Expand Up @@ -76,6 +76,5 @@ def test_list_dlp_jobs_with_job_type(capsys):
assert 'Job: projects/' in out


def test_delete_dlp_job(capsys):
test_job_name = create_test_job()
def test_delete_dlp_job(test_job_name, capsys):
jobs.delete_dlp_job(GCLOUD_PROJECT, test_job_name)
2 changes: 1 addition & 1 deletion dlp/quickstart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def quickstart(project_id):
}

# Convert the project id into a full resource id.
parent = dlp_client.project_path(project)
parent = dlp_client.project_path(project_id)

# Call the API.
response = dlp_client.inspect_content(parent, inspect_config, item)
Expand Down
2 changes: 1 addition & 1 deletion dlp/quickstart_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def test_quickstart(capsys):
google.cloud.dlp.DlpServiceClient,
'project_path',
return_value='projects/{}'.format(GCLOUD_PROJECT)):
quickstart.quickstart()
quickstart.quickstart(GCLOUD_PROJECT)

out, _ = capsys.readouterr()
assert 'FIRST_NAME' in out
Expand Down
10 changes: 5 additions & 5 deletions dlp/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
google-cloud-dlp==0.9.0
google-cloud-storage==1.13.0
google-cloud-pubsub==0.38.0
google-cloud-datastore==1.7.1
google-cloud-bigquery==1.7.0
google-cloud-dlp==0.10.0
google-cloud-storage==1.13.2
google-cloud-pubsub==0.39.1
google-cloud-datastore==1.7.3
google-cloud-bigquery==1.8.1
Loading