Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move in ndb queries code snippets & tests #296

Merged
merged 2 commits into from
Apr 28, 2016
Merged

Move in ndb queries code snippets & tests #296

merged 2 commits into from
Apr 28, 2016

Conversation

jerjou
Copy link
Contributor

@jerjou jerjou commented Apr 28, 2016

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 28, 2016
@jerjou jerjou force-pushed the ndb-queries branch 3 times, most recently from 3b57028 to 1af9a59 Compare April 28, 2016 03:46


class Greeting(ndb.Model):
'''Models an individual Guestbook entry with content and date.'''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be double quotes for docstrings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@waprin
Copy link
Contributor

waprin commented Apr 28, 2016

minor nits to consider, overall lgtm, nice tests

@jerjou jerjou force-pushed the ndb-queries branch 2 times, most recently from b28da9d to 91065a3 Compare April 28, 2016 17:37
@jerjou
Copy link
Contributor Author

jerjou commented Apr 28, 2016

rebased on master. Will merge when travis gives the okay.

@jerjou jerjou merged commit 6825c63 into master Apr 28, 2016
@jerjou jerjou deleted the ndb-queries branch April 28, 2016 21:31
msampathkumar pushed a commit that referenced this pull request Nov 14, 2022
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
arbrown pushed a commit that referenced this pull request Nov 14, 2022
Source-Link: googleapis/synthtool@4760d8d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
dandhlee pushed a commit that referenced this pull request Nov 15, 2022
Source-Link: googleapis/synthtool@4760d8d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
telpirion pushed a commit that referenced this pull request Dec 2, 2022
* fix: fix path to products files.

* Fix path creation. Move gcs bucket creation logic to the function.

Co-authored-by: nicain <nicholascain@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dandhlee pushed a commit that referenced this pull request Dec 2, 2022
* fix: fix path to products files.

* Fix path creation. Move gcs bucket creation logic to the function.

Co-authored-by: nicain <nicholascain@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants