Making nox skip unchanged samples. #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I4e2c41f0b522d4ca2a9d1ea15e705d86d640936b
googlebot
added
the
cla: yes
| os.environ.get('TRAVIS_COMMIT'), | ||
| os.environ.get('TRAVIS_BRANCH')]) | ||
| else: | ||
| changed = '' |
There was a problem hiding this comment.
maybe raise since this should never happen?
There was a problem hiding this comment.
Not yet, I want to keep an eye on this first.
|
code lgtm...i feel like some of the nox.py could be refactored to be a bit more declarative but im still thinking out how. |
|
Yeah, I cleaned it up a bit this round, but I'm wondering how much more we could clean it and how much of this we could shove in to repo-tools. |
donmccasland
pushed a commit
that referenced
this pull request
Nov 11, 2022
8 tasks
msampathkumar
pushed a commit
that referenced
this pull request
Nov 14, 2022
Source-Link: googleapis/synthtool@6fab84a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7cffbc10910c3ab1b852c05114a08d374c195a81cdec1d4a67a1d129331d0bfe
8 tasks
arbrown
pushed a commit
that referenced
this pull request
Nov 14, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 15, 2022
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Jan 13, 2023
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
dandhlee
pushed a commit
that referenced
this pull request
Jan 26, 2023
dandhlee
pushed a commit
that referenced
this pull request
Feb 9, 2023
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.