Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create dockerfile to run echo service #330

Merged
merged 3 commits into from
May 6, 2016
Merged

create dockerfile to run echo service #330

merged 3 commits into from
May 6, 2016

Conversation

wenchenglu
Copy link

endpoints alpha doc will need to link to this dockerfile

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 5, 2016
@theacodes
Copy link
Contributor

This will actually break the flexible samples, as the presence of a Dockerfile will cause gcloud app deploy to complain about runtime not being set to custom.

We have two options:

  • We could put the Dockerfile elsewhere or by a different name and tell the user to copy it.
  • we can duplicate this sample to container_engine/endpoints.

@wenchenglu
Copy link
Author

if I rename this to echo.Dockerfile, will this solve that problem?

By the way, like the idea of having a sample in container_engine/endpoints. But I am hesitating on causing code duplicacy. Let me know what you would prefer :)

@wenchenglu
Copy link
Author

they don't need to copy it. we document in the user doc and ask them to run:
docker build -t image_path ./echo.Dockerfile

@theacodes
Copy link
Contributor

I'd prefer Dockerfile.container-engine.

@wenchenglu
Copy link
Author

done. in the same directory? not sure if this will pass the CI.

By the way, this sample will be used for both gce and gke.

@theacodes
Copy link
Contributor

For the record @wlu2016 is a Googler and no CLA is needed.

FROM debian:jessie

RUN apt-get update && \
apt-get install -y python2.7 python-pip python-gevent && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gevent shouldn't be needed.

@wenchenglu
Copy link
Author

done ptal

@theacodes
Copy link
Contributor

LGTM.

@theacodes theacodes merged commit b449a55 into GoogleCloudPlatform:master May 6, 2016
donmccasland pushed a commit that referenced this pull request Nov 11, 2022
…#330)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 25, 2023
- feat(samples): private CA python samples
- chore(deps): update dependency google-cloud-private-ca to v1 (#89)
- chore(deps): update dependency google-cloud-kms to v2.4.1 (#88)
- chore(deps): update dependency google-cloud-kms to v2.4.2 (#93)
- chore(deps): update dependency google-auth to v1.33.1 (#87)
- chore(deps): update dependency google-auth to v1.34.0 (#94)
- chore(deps): update dependency google-cloud-kms to v2.4.3 (#96)
- chore(deps): update dependency google-cloud-private-ca to v1.0.3 (#97)
- feat(samples): add local generation for crypto keys (#98)
- chore(deps): update dependency google-cloud-kms to v2.5.0 (#101)
- chore: generate python samples templates in owlbot.py (#108)
- chore(deps): update dependency cryptography to v3.4.8 (#109)
- chore(deps): update dependency google-auth to v2 (#107)
- chore(deps): update dependency google-cloud-private-ca to v1.0.4 (#103)
- chore(deps): update dependency google-auth to v2.0.2 (#116)
- chore(deps): update dependency google-cloud-kms to v2.6.0 (#115)
- chore(deps): update dependency pytest to v6.2.5 (#114)
- chore: blacken samples noxfile template (#121)
- chore: fail samples nox session if python version is missing (#128)
- chore(python): Add kokoro configs for python 3.10 samples testing (#134)
- chore(deps): update dependency google-auth to v2.1.0 (#120)
- chore(deps): update all dependencies (#144)
- chore(deps): update all dependencies (#146)
- chore(deps): update dependency google-cloud-private-ca to v1.2.1 (#147)
- chore(python): run blacken session for all directories with a noxfile (#150)
- chore(deps): update dependency cryptography to v36 (#154)
- feat(samples): add subordinate CA samples
- chore(deps): update dependency cryptography to v36.0.1 (#158)
- chore(samples): Add check for tests in directory (#164)
- chore(python): Noxfile recognizes that tests can live in a folder (#169)
- docs(samples): add sample to filter certificates (#160)
- chore(deps): update dependency google-auth to v2.6.0 (#173)
- docs(samples): add template/monitoring samples (#174)
- chore(deps): update all dependencies (#178)
- chore(deps): update all dependencies (#186)
- chore: Adding support for pytest-xdist and pytest-parallel (#193)
- chore(deps): update all dependencies (#196)
- chore(deps): update dependency google-cloud-private-ca to v1.3.0 (#199)
- chore(deps): update dependency pytest to v7.1.0 (#200)
- chore(deps): update dependency cryptography to v36.0.2 (#201)
- chore(deps): update all dependencies (#202)
- chore(python): use black==22.3.0 (#204)
- chore(deps): update dependency google-auth to v2.6.3 (#211)
- chore(deps): update dependency google-auth to v2.6.4 (#215)
- chore(deps): update dependency google-auth to v2.6.5 (#217)
- chore(python): add nox session to sort python imports (#218)
- chore(deps): update dependency google-auth to v2.6.6 (#221)
- chore(deps): update dependency pytest to v7.1.2 (#222)
- chore(deps): update dependency cryptography to v37 (#223)
- chore(deps): update dependency cryptography to v37.0.1 (#225)
- chore(deps): update dependency cryptography to v37.0.2 (#226)
- chore(deps): update dependency google-cloud-private-ca to v1.3.1 (#230)
- fix: require python 3.7+ (#267)
- chore(deps): update all dependencies (#262)
- chore(deps): update all dependencies (#273)
- chore(deps): update all dependencies (#275)
- chore(deps): update all dependencies (#276)
- chore(deps): update dependency google-cloud-monitoring to v2.11.1 (#281)
- chore(deps): update all dependencies (#283)
- chore(deps): update dependency google-auth to v2.11.0 (#284)
- chore(deps): update dependency pytest to v7.1.3 (#294)
- chore: Bump gapic-generator-python version to 1.3.0 (#295)
- chore: detect samples tests in nested directories (#299)
- chore(deps): update dependency google-auth to v2.11.1 (#300)
- chore(deps): update dependency google-auth to v2.12.0 (#302)
- chore(deps): update all dependencies (#304)
- chore(deps): update all dependencies (#307)
- chore(deps): update dependency pytest to v7.2.0 (#308)
- chore(deps): update dependency google-auth to v2.14.0 (#310)
- chore(python): drop flake8-import-order in samples noxfile (#315)
- chore(deps): update all dependencies (#311)
- chore(deps): update dependency cryptography to v38.0.4 (#317)
- chore(deps): update dependency google-auth to v2.15.0 (#318)
- chore(deps): update all dependencies (#321)
- chore(deps): update dependency google-cloud-private-ca to v1.5.0 (#322)
- chore(deps): update dependency cryptography to v39 (#323)
- chore(python): add support for python 3.11 (#324)
- chore(deps): update dependency google-cloud-monitoring to v2.13.0 (#325)
- chore(deps): update dependency google-auth to v2.16.0 (#326)
- chore(deps): update all dependencies (#329)
- chore(deps): update dependency pytest to v7.2.1 (#330)

## Description

Sample Migration from googleapis/python-security-private-ca

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

## Checklist
- [ ] I have followed [Sample Guidelines from AUTHORING_GUIDE.MD](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md)
- [ ] README is updated to include [all relevant information](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#readme-file)
- [ ] **Tests** pass:   `nox -s py-3.9` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup))
- [ ] **Lint** pass:   `nox -s lint` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup))
- [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones)
- [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones)
- [ ] Please **merge** this PR for me once it is approved.
- [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/.github/CODEOWNERS) with the codeowners for this sample
dandhlee pushed a commit that referenced this pull request Jan 26, 2023
…#330)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sita04 added a commit that referenced this pull request Feb 7, 2023
* docs(dlp-samples): modified region tags and fixed comment

* lint fix
telpirion pushed a commit that referenced this pull request Mar 13, 2023
- feat(samples): private CA python samples
- chore(deps): update dependency google-cloud-private-ca to v1 (#89)
- chore(deps): update dependency google-cloud-kms to v2.4.1 (#88)
- chore(deps): update dependency google-cloud-kms to v2.4.2 (#93)
- chore(deps): update dependency google-auth to v1.33.1 (#87)
- chore(deps): update dependency google-auth to v1.34.0 (#94)
- chore(deps): update dependency google-cloud-kms to v2.4.3 (#96)
- chore(deps): update dependency google-cloud-private-ca to v1.0.3 (#97)
- feat(samples): add local generation for crypto keys (#98)
- chore(deps): update dependency google-cloud-kms to v2.5.0 (#101)
- chore: generate python samples templates in owlbot.py (#108)
- chore(deps): update dependency cryptography to v3.4.8 (#109)
- chore(deps): update dependency google-auth to v2 (#107)
- chore(deps): update dependency google-cloud-private-ca to v1.0.4 (#103)
- chore(deps): update dependency google-auth to v2.0.2 (#116)
- chore(deps): update dependency google-cloud-kms to v2.6.0 (#115)
- chore(deps): update dependency pytest to v6.2.5 (#114)
- chore: blacken samples noxfile template (#121)
- chore: fail samples nox session if python version is missing (#128)
- chore(python): Add kokoro configs for python 3.10 samples testing (#134)
- chore(deps): update dependency google-auth to v2.1.0 (#120)
- chore(deps): update all dependencies (#144)
- chore(deps): update all dependencies (#146)
- chore(deps): update dependency google-cloud-private-ca to v1.2.1 (#147)
- chore(python): run blacken session for all directories with a noxfile (#150)
- chore(deps): update dependency cryptography to v36 (#154)
- feat(samples): add subordinate CA samples
- chore(deps): update dependency cryptography to v36.0.1 (#158)
- chore(samples): Add check for tests in directory (#164)
- chore(python): Noxfile recognizes that tests can live in a folder (#169)
- docs(samples): add sample to filter certificates (#160)
- chore(deps): update dependency google-auth to v2.6.0 (#173)
- docs(samples): add template/monitoring samples (#174)
- chore(deps): update all dependencies (#178)
- chore(deps): update all dependencies (#186)
- chore: Adding support for pytest-xdist and pytest-parallel (#193)
- chore(deps): update all dependencies (#196)
- chore(deps): update dependency google-cloud-private-ca to v1.3.0 (#199)
- chore(deps): update dependency pytest to v7.1.0 (#200)
- chore(deps): update dependency cryptography to v36.0.2 (#201)
- chore(deps): update all dependencies (#202)
- chore(python): use black==22.3.0 (#204)
- chore(deps): update dependency google-auth to v2.6.3 (#211)
- chore(deps): update dependency google-auth to v2.6.4 (#215)
- chore(deps): update dependency google-auth to v2.6.5 (#217)
- chore(python): add nox session to sort python imports (#218)
- chore(deps): update dependency google-auth to v2.6.6 (#221)
- chore(deps): update dependency pytest to v7.1.2 (#222)
- chore(deps): update dependency cryptography to v37 (#223)
- chore(deps): update dependency cryptography to v37.0.1 (#225)
- chore(deps): update dependency cryptography to v37.0.2 (#226)
- chore(deps): update dependency google-cloud-private-ca to v1.3.1 (#230)
- fix: require python 3.7+ (#267)
- chore(deps): update all dependencies (#262)
- chore(deps): update all dependencies (#273)
- chore(deps): update all dependencies (#275)
- chore(deps): update all dependencies (#276)
- chore(deps): update dependency google-cloud-monitoring to v2.11.1 (#281)
- chore(deps): update all dependencies (#283)
- chore(deps): update dependency google-auth to v2.11.0 (#284)
- chore(deps): update dependency pytest to v7.1.3 (#294)
- chore: Bump gapic-generator-python version to 1.3.0 (#295)
- chore: detect samples tests in nested directories (#299)
- chore(deps): update dependency google-auth to v2.11.1 (#300)
- chore(deps): update dependency google-auth to v2.12.0 (#302)
- chore(deps): update all dependencies (#304)
- chore(deps): update all dependencies (#307)
- chore(deps): update dependency pytest to v7.2.0 (#308)
- chore(deps): update dependency google-auth to v2.14.0 (#310)
- chore(python): drop flake8-import-order in samples noxfile (#315)
- chore(deps): update all dependencies (#311)
- chore(deps): update dependency cryptography to v38.0.4 (#317)
- chore(deps): update dependency google-auth to v2.15.0 (#318)
- chore(deps): update all dependencies (#321)
- chore(deps): update dependency google-cloud-private-ca to v1.5.0 (#322)
- chore(deps): update dependency cryptography to v39 (#323)
- chore(python): add support for python 3.11 (#324)
- chore(deps): update dependency google-cloud-monitoring to v2.13.0 (#325)
- chore(deps): update dependency google-auth to v2.16.0 (#326)
- chore(deps): update all dependencies (#329)
- chore(deps): update dependency pytest to v7.2.1 (#330)

## Description

Sample Migration from googleapis/python-security-private-ca

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

## Checklist
- [ ] I have followed [Sample Guidelines from AUTHORING_GUIDE.MD](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md)
- [ ] README is updated to include [all relevant information](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#readme-file)
- [ ] **Tests** pass:   `nox -s py-3.9` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup))
- [ ] **Lint** pass:   `nox -s lint` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup))
- [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones)
- [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones)
- [ ] Please **merge** this PR for me once it is approved.
- [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/.github/CODEOWNERS) with the codeowners for this sample
telpirion pushed a commit that referenced this pull request Mar 13, 2023
…#330)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants