-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[automl] fix: retry vision_object_detection_predict.predict #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes GoogleCloudPlatform#3415 Also setting a hard deadline for model deployment.
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Apr 23, 2020
kurtisvg
approved these changes
Apr 24, 2020
It doesn't affect the published sample, also the infinite loop is bad for our tests and build-cop-bot, so I'm going to merge this. @telpirion @sirtorry @nnegrey Let me know if you have concerns. |
tmatsuo
added
automerge
Merge the pull request once unit tests and other checks pass.
and removed
automerge
Merge the pull request once unit tests and other checks pass.
labels
Apr 24, 2020
nnegrey
reviewed
Apr 24, 2020
@@ -32,12 +34,17 @@ def verify_model_state(): | |||
if model.deployment_state == automl.enums.Model.DeploymentState.UNDEPLOYED: | |||
# Deploy model if it is not deployed | |||
response = client.deploy_model(model_full_id) | |||
response.result() | |||
response.result(600) # 10 minutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be worth bumping this to 30 minutes.
Model Deployement is really slow
leahecole
pushed a commit
that referenced
this pull request
Apr 24, 2020
fixes #3415 Also setting a hard deadline for model deployment.
busunkim96
pushed a commit
to busunkim96/python-automl
that referenced
this pull request
Aug 7, 2020
…oogleCloudPlatform/python-docs-samples#3492) fixes #3415 Also setting a hard deadline for model deployment.
busunkim96
pushed a commit
to googleapis/python-automl
that referenced
this pull request
Aug 11, 2020
…oogleCloudPlatform/python-docs-samples#3492) fixes #3415 Also setting a hard deadline for model deployment.
arbrown
pushed a commit
that referenced
this pull request
Nov 17, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 17, 2022
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 21, 2023
…oogleCloudPlatform/python-docs-samples#3492) fixes #3415 Also setting a hard deadline for model deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3415
Also setting a hard deadline for model deployment.