Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automl] fix: retry vision_object_detection_predict.predict #3492

Merged
merged 3 commits into from
Apr 24, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Apr 23, 2020

fixes #3415

Also setting a hard deadline for model deployment.

fixes GoogleCloudPlatform#3415

Also setting a hard deadline for model deployment.
@tmatsuo tmatsuo requested a review from nnegrey April 23, 2020 23:40
@tmatsuo tmatsuo requested review from sirtorry, telpirion and a team as code owners April 23, 2020 23:40
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Apr 24, 2020

It doesn't affect the published sample, also the infinite loop is bad for our tests and build-cop-bot, so I'm going to merge this. @telpirion @sirtorry @nnegrey Let me know if you have concerns.

@tmatsuo tmatsuo added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Apr 24, 2020
@tmatsuo tmatsuo merged commit 86a552c into GoogleCloudPlatform:master Apr 24, 2020
@tmatsuo tmatsuo deleted the fix-automl branch April 24, 2020 05:10
@@ -32,12 +34,17 @@ def verify_model_state():
if model.deployment_state == automl.enums.Model.DeploymentState.UNDEPLOYED:
# Deploy model if it is not deployed
response = client.deploy_model(model_full_id)
response.result()
response.result(600) # 10 minutes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be worth bumping this to 30 minutes.
Model Deployement is really slow

leahecole pushed a commit that referenced this pull request Apr 24, 2020
fixes #3415

Also setting a hard deadline for model deployment.
busunkim96 pushed a commit to busunkim96/python-automl that referenced this pull request Aug 7, 2020
busunkim96 pushed a commit to googleapis/python-automl that referenced this pull request Aug 11, 2020
arbrown pushed a commit that referenced this pull request Nov 17, 2022
…3492)

fixes #3415

Also setting a hard deadline for model deployment.
dandhlee pushed a commit that referenced this pull request Nov 17, 2022
…3492)

fixes #3415

Also setting a hard deadline for model deployment.
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automl.cloud-client.vision_object_detection_predict_test: test_vision_object_detection_predict failed
4 participants