IAM: update quickstart comments #4716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
busunkim96
approved these changes
Sep 21, 2020
product-auto-label
bot
added
api: iam
kurtisvg
approved these changes
Sep 22, 2020
iam/api-client/quickstartv2.py
Outdated
| member = "your_member" | ||
| project_id = "your-project-id" | ||
| # TODO: Replace with the ID of your member in the form | ||
| # 'user|group|serviceAccount:email' or 'domain:domain' |
There was a problem hiding this comment.
Can we add a link to the IAM reference documentation for this format?
There was a problem hiding this comment.
Added. The link has some good examples of what member should look like.
kurtisvg
approved these changes
Sep 22, 2020
|
Since this is a quickstart and we want to be as directive as possible, I would prefer not to give the user multiple options for the member type. We're assuming at this point that they will be testing out IAM by adding a user. The goal of the quickstart is just to give users a first-touch experience with IAM. If we need to instruct users about how to modify policy, including modifying policy for different member types, we should use the Granting, changing, and revoking access page, and/or the access sample. |
anguillanneuf
changed the title
user:email in comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://cloud.google.com/sdk/gcloud/reference/iam/service-accounts/add-iam-policy-binding#--member