-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new django tutorial #4869
Add new django tutorial #4869
Conversation
…amples into tutorial/django-run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Is there any more background to this sample? Will it be included under cloud.google.com/run? If not, maybe we can host the sample in a community tutorial folder with our other cloud run tutorials.
Is the tutorial original? I didn't review the code as it doesn't seem to be originally authored.
CC @grayside
run/django/README.md
Outdated
This repository is an example of how to run a [Django](https://www.djangoproject.com/) | ||
app on Google Cloud Run (fully managed). | ||
|
||
The Django application used in this tutorial is the [Writing your first Django app](https://docs.djangoproject.com/en/3.0/#first-steps), after completing [Part 1](https://docs.djangoproject.com/en/3.0/intro/tutorial01/) and [Part 2](https://docs.djangoproject.com/en/3.0/intro/tutorial02/)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we 100% sure that Google authored this code and we're able to claim it under this repo's license? It seems like this tutorial should be hosted on Django's website/repo and not here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the pattern from the kubernetes and appengine samples.
Linting was failing since typechecks are currently configured to include typechecking noxfile.py itself, which is copied per workspace from ~/noxfile-template.py. " Happy to cherrypick these comments to a different branch and rebase this branch, for code cleanliness. (This branch also needs a squash, maybe, not seeing anything in AUTHORING_GUIDE about such things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending test passing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor changes! Ping me when you're ready for what is most likely the final review
Description
Implements new Django tutorial with integration testing. (Internal cl/309679445)
Checklist
nox -s py-3.6
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)