Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in BQ Standard SQL samples. #536

Merged
merged 1 commit into from
Sep 20, 2016
Merged

Typo in BQ Standard SQL samples. #536

merged 1 commit into from
Sep 20, 2016

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Sep 19, 2016

The parameter is useLegacySql not useLegacySQL. See:
https://code.google.com/p/google-bigquery/issues/detail?id=701

I also update the tests to use a query that only works with standard SQL
for those tests.

The parameter is useLegacySql not useLegacySQL. See:
https://code.google.com/p/google-bigquery/issues/detail?id=701

I also update the tests to use a query that only works with standard SQL
for those tests.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 19, 2016
@theacodes
Copy link
Contributor

@dpebot please merge when travis passes

@dpebot
Copy link
Collaborator

dpebot commented Sep 19, 2016

Okay! I'll merge when all statuses are green.

@dpebot dpebot added the automerge Merge the pull request once unit tests and other checks pass. label Sep 19, 2016
@tswast
Copy link
Contributor Author

tswast commented Sep 20, 2016

@jonparrott The Travis failure seems unrelated to this change. Pip can't install the cryptography library.

  Running setup.py bdist_wheel for cryptography: finished with status 'error'
  Complete output from command /home/travis/build/GoogleCloudPlatform/python-docs-samples/.nox/travis-subsession-tests/bin/python3.5 -u -c "import setuptools, tokenize;__file__='/tmp/pip-build-i5ug1jdx/cryptography/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" bdist_wheel -d /tmp/tmp7v1a65_2pip-wheel- --python-tag cp35:
  c/_cffi_backend.c:2:20: fatal error: Python.h: No such file or directory

@theacodes
Copy link
Contributor

@tswast I fixed that in master, your branch might not have picked it up. I'll merge anyway.

@theacodes theacodes merged commit 1e9a655 into master Sep 20, 2016
@theacodes theacodes deleted the tswast-bq branch September 20, 2016 16:45
telpirion pushed a commit that referenced this pull request Jan 18, 2023
dandhlee pushed a commit that referenced this pull request Feb 6, 2023
telpirion pushed a commit that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants