Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove 2.x ci trigger #2059

Merged
merged 2 commits into from
Sep 20, 2023
Merged

chore: remove 2.x ci trigger #2059

merged 2 commits into from
Sep 20, 2023

Conversation

meltsufin
Copy link
Member

No description provided.

@meltsufin meltsufin requested a review from a team as a code owner July 25, 2023 17:27
@meltsufin meltsufin requested a review from ddixit14 July 25, 2023 17:27
ddixit14
ddixit14 reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@ddixit14 ddixit14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these changes already done in https://github.com/GoogleCloudPlatform/spring-cloud-gcp/pull/2058/files ? introducing 3.x and removing 2.x in sonal.yaml and unittests.yaml

@meltsufin
Copy link
Member Author

Aren't these changes already done in https://github.com/GoogleCloudPlatform/spring-cloud-gcp/pull/2058/files ? introducing 3.x and removing 2.x in sonal.yaml and unittests.yaml

This is for the main branch, and the other one is for 3.x branch. They need to be in sync.

@meltsufin meltsufin enabled auto-merge (squash) July 25, 2023 17:59
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@meltsufin meltsufin merged commit 1dea22e into main Sep 20, 2023
28 of 29 checks passed
@meltsufin meltsufin deleted the remove-2.x-from-ci branch September 20, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddixit14 ddixit14 ddixit14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meltsufin @ddixit14