add network_url attribute in consumer_accept_list block of google_compute_service_attachment resource #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pute_service_attachment resource (#9895) * add network_url attribute in consumer_accept_list block of google_compute_service_attachment resource * Bugfix: Use SelfLinkRelativePath check to prevent false positive resource changes [upstream:0249d74bdb046afe63b6562f40b7cfa315eeb8b2] Signed-off-by: Modular Magician <magic-modules@google.com>
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
network_urlattribute to theconsumer_accept_list-block of thegoogle_compute_service_attachmentresource.Note that because ExactlyOneOf is not available for lists, the
projectIdOrNumattribute is made optional. Issue: hashicorp/terraform-plugin-sdk#470Fixes:
networkUrltoconsumerAcceptListsincompute_service_attachmenthashicorp/terraform-provider-google#15203An
service_attachment_explicit_networksexample is added to demonstrate the functionality and acts as an acceptance test.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9895