Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new resource Workload for Apphub #2047

Conversation

modular-magician
Copy link
Collaborator

Add resource for registering identified Workload to the Application
FIXES hashicorp/terraform-provider-google#17539

Based on other PR:

  1. Add data source for AppHub discovered workload magic-modules#10107

Release Note Template for Downstream PRs (will be copied)

`google_apphub_workload`

Derived from GoogleCloudPlatform/magic-modules#10155

* Add new resource Workload for Apphub

* Fix lint error

* Add billing account

* Remove extra delay from test

* Resolve comments

* Add handwritten update test

* Fix lint error

* Add data source changes

* Remove merged changes

* Remove merged changes

* Batch all update tests into one step to make test fast

* Add a delay between discovered resource fetch and managed instance group manager creation

* Add back org_id

* Update region from us-east1 to us-central1

* Use standard diff suppress function

---------

Co-authored-by: praseedhaPK <161299686+praseedhaPK@users.noreply.github.com>
Co-authored-by: Krishnan Gopal <krishgopal@google.com>

[upstream:ca62aed93eb3f92e915a5041fb0ab5c32ff99475]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner March 13, 2024 01:54
@modular-magician modular-magician requested review from melinath and removed request for a team March 13, 2024 01:54
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit 1cc0f77 into GoogleCloudPlatform:main Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New resource for Workload in Apphub
1 participant