Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Google HTTP libraries #3745

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Upgrade Google HTTP libraries #3745

merged 2 commits into from
Sep 2, 2022

Conversation

emmileaf
Copy link
Contributor

@emmileaf emmileaf commented Aug 25, 2022 •
edited
Loading

Resolves #3416.

Upgrade previously downgraded Google HTTP and auth libraries (#3415) back to latest version, per #3416 (comment).

@emmileaf emmileaf changed the title Update Google HTTP libraries Upgrade Google HTTP libraries Aug 25, 2022
@emmileaf emmileaf marked this pull request as ready for review August 25, 2022 19:58
@emmileaf emmileaf requested a review from elefeint August 25, 2022 20:02
@elefeint elefeint requested a review from mpeddada1 August 25, 2022 22:11
mpeddada1
mpeddada1 approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@mpeddada1 mpeddada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Have we also tested this on the continuous build?

@emmileaf
Copy link
Contributor Author

emmileaf commented Sep 2, 2022

Yup! The continuous builds triggered from this commit were also passing.

@mpeddada1
Copy link
Contributor

Cool! We've released the plugins/core so feel free to merge this PR.

@emmileaf
Copy link
Contributor Author

emmileaf commented Sep 2, 2022

Sounds good - let me rebase and sort out the changelogs now that we have the new releases, then will merge.

@emmileaf emmileaf force-pushed the upgrade-http-libraries branch from c6f4c1e to eb1d73e Compare September 2, 2022 18:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@emmileaf emmileaf merged commit ab0da54 into master Sep 2, 2022
@emmileaf emmileaf deleted the upgrade-http-libraries branch September 2, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpeddada1 mpeddada1 mpeddada1 approved these changes

@elefeint elefeint Awaiting requested review from elefeint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot upgrade Google HTTP libraries
2 participants
@emmileaf @mpeddada1