Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add compile-generator workaround for SLSA #3848

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Conversation

emmileaf
Copy link
Contributor

Latest attempts to release Jib CLI v0.12.0 has been running into SLSA (added in #3722, #3726) issues similar to described in slsa-framework/slsa-github-generator#1163 (comment).

We have bumped slsa-github-generator version to v1.2.1, and this PR adds the suggested compile-generator: true workaround.

@laurentsimon @ianlewis Would you be able to help provide any additional pointers or context on this issue?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@laurentsimon
Copy link
Contributor

laurentsimon commented Oct 28, 2022

this was a temporary problem due to Sigstore going GA with non-backward compatibility changes. @asraa worked on the fixes and will have more context to comment; and have a timeline when you can remove the compile-generator: true option. Sorry for the inconvenience again. And thanks for letting us know about the problem

This was referenced Oct 28, 2022
@emmileaf
Copy link
Contributor Author

this was a temporary problem due to Sigstore going GA with non-backward compatibility changes. @asraa worked on the fixes and will have more context to comment; and have a timeline when you can remove the compile-generator: true option. Sorry for the inconvenience again. And thanks for letting us know about the problem

Thank you, the context and timeline for removing the workaround would be helpful! Will merge this PR to try the release again, but feel free to add more comments to this thread and I will open an issue later to track its removal.

@asraa
Copy link

asraa commented Oct 31, 2022

Thank you, the context and timeline for removing the workaround would be helpful!

Adding in some context here!
The breakage was due to slsa-framework/slsa-github-generator#1163 (comment)

tldr; Context: Sigstore GA went last week and as part of that, we updated the online TUF root where the root of trust is fetched to a TUF-compliant format. This broke old clients, and we have regressions in place with other TUF clients now to detect this. At some point that needed to happen and we decided GA was the right time. The old TUF clients in older Sigstore versions do not understand the new format.

Timeline: We're currently releasing backports of slsa-verifier that includes this fix, and should have slsa-github-generator updated with a new version in the next week. We're trying to figure out faster ways to workaround these types of issues: slsa-framework/slsa-github-generator#1175 and add docs on known issues.

@emmileaf
Copy link
Contributor Author

@asraa Thanks for the info! The workaround unblocked our latest release, but we'll keep an eye out to make the version update and remove it when no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants