Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always add parent directories of files to snapshots. #1166

Merged

Commits on Mar 29, 2020

  1. Always add parent directories of files to snapshots.

    During a snapshot, when a file changed and not its parent directories,
    the parent directories weren't added to the layer. This is inconsistent
    with Docker's behavior which always add parent directories to the layer.
    In some edge-cases, it could lead to problems with docker considering
    that parent directories where owned by root in forthcoming layers
    although they shouldn't (see GoogleContainerTools#1163).
    
    Also, Docker seems to be POSIX compliant regarding the name of
    directories in the archive, which always have a slash appended. This
    commit also fixes this.
    
    Fixes GoogleContainerTools#1163
    gilbsgilbs committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    e5585fd View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. Configuration menu
    Copy the full SHA
    fd8a2d6 View commit details
    Browse the repository at this point in the history
  2. Fix sorting of parent directories.

    This refactoring reversed the order of the "ParentDirectories" function: GoogleContainerTools@ffc372a#diff-d36eb675aa49a7b471e3a2be77005b18R465
    
    As a side-effect, parent directories weren't added in lexicographical
    order, which broke some tests. We now ensure in unit test that the order
    of the ParentDirectories function is stable.
    gilbsgilbs committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    14170aa View commit details
    Browse the repository at this point in the history