Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicates save for the same dir #1252

Merged
merged 1 commit into from
May 8, 2020
Merged

remove duplicates save for the same dir #1252

merged 1 commit into from
May 8, 2020

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented May 7, 2020

Fixes #1111
Description

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

@googlebot googlebot added the cla: yes CLA signed by all commit authors label May 7, 2020
@tejal29 tejal29 mentioned this pull request May 7, 2020
Closed
@tejal29 tejal29 merged commit f5e2357 into GoogleContainerTools:master May 8, 2020
@tejal29 tejal29 deleted the fix_double_save branch April 26, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

COPY resolves symlinks it shouldn't try to resolve
2 participants
@tejal29 @googlebot