Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recurse submodules #1320

Merged
merged 1 commit into from
Jun 23, 2020
Merged

feat: recurse submodules #1320

merged 1 commit into from
Jun 23, 2020

Conversation

caarlos0
Copy link
Contributor

Description

I think it's safe to assume that most people will want their submodules to be cloned as well. This adds that option to our go-git cloning.

Something I'm not sure about is how to test it. Should we create a phony git repo somewhere with submodules so we can add tests here?

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

- kaniko now clone git repositories recursing submodules by default

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@googlebot googlebot added the cla: yes CLA signed by all commit authors label Jun 15, 2020
@aca
Copy link
Contributor

aca commented Jun 16, 2020

Faced the same issue.

Tried it but having authentication issue.
When kaniko context is set like this It fails to clone submodules
git://{token}@github.mycompany.com/org/repo.git#refs/heads/master

Do you have any clue for this?

@tejal29 tejal29 merged commit 1231c77 into GoogleContainerTools:master Jun 23, 2020
@aca
Copy link
Contributor

aca commented Jun 24, 2020

Faced the same issue.

Tried it but having authentication issue.
When kaniko context is set like this It fails to clone submodules
git://{token}@github.mycompany.com/org/repo.git#refs/heads/master

Do you have any clue for this?

If anyone face the same issue.
Try using GIT_USERNAME instead of adding token in context.
Clone options in kaniko should be fixed...

Still, only submodules with http protocol would work, https://

@caarlos0 caarlos0 deleted the recurse branch June 24, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants