-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-arch image via Bazel #1452
Conversation
I'm staging this to test the Travis integration, but I need to make the cc @tejal29 |
Travis seems to have not gotten notified, or is otherwise upset with me... 🤔 |
c9cb67f
to
de77939
Compare
Alright, commenting the travis changes seems to have unwedged it. I "love" silent failures 🙃 |
1a38e8e
to
582844d
Compare
Looks like we need to switch to paid tier for travis. |
73a09d2
to
c9db834
Compare
Alright, my stripped down Travis build passed, so I uncommented everything here: https://travis-ci.org/github/GoogleContainerTools/kaniko/builds/734073723 This should be RFAL, please look carefully at the |
Everything is green! 🤩 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except some nits on code organization.
Alright, looks like the previous failure was a flake, so this should be RFAL. |
@tejal29 LMK if these needs anything else! |
I will share the results of GCB tirgger with you. |
This reverts commit a310cc6.
Description
This starts to add multi-arch container images built via Bazel, turned into "manifest lists" in the Docker daemon, and published.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes