Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option customPlatform #1500

Merged
merged 3 commits into from
Dec 9, 2020
Merged

Conversation

mickkael
Copy link
Contributor

@mickkael mickkael commented Nov 21, 2020

Fixes #1491

Description

Add the option customPlatform to the cmd to specify a different platform while building the container with kaniko. This is not virtualization, so the specified platform must be compatible with the host. Like build arm32 on an arm64 host, or build i386 on an amd64 host.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

Not sure where to put the unit tests

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.


- kaniko adds a new flag `--customPlatform GOOS/GOARCH` to build the container for a platform different but compatible with the build host (arm32 on an arm64 host, or build i386 on an amd64 host)

@google-cla google-cla bot added the cla: yes CLA signed by all commit authors label Nov 21, 2020
Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you so much!!!

@tejal29 tejal29 merged commit 275cc9a into GoogleContainerTools:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross platform build with Kaniko
2 participants