Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds ignore-path command arguments to executor #1622

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

jonfriesen
Copy link
Contributor

@jonfriesen jonfriesen commented Apr 7, 2021

Fixes #1621

Description

Allows the command line setting of custom ignore paths via the executor. This follows the style of /kaniko/executor --ignore-path /first/path --ignore-path /second/path.

This change renames initialIgnoreList with defaultIgnoreList and creates a baseIgnoreList which is assigned to ignoreList. This allows ignore paths to be added via the command line --ignore-path argument that persists across DetectFilesystemIgnoreList(...) calls while still allowing the ignoreList to be reset from changes made in flight.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

  • adds --ignore-path executor argument to allow custom ignore-path's to be set. This command can be used repeatedly for multiple paths.

@google-cla google-cla bot added the cla: yes CLA signed by all commit authors label Apr 7, 2021
@jonfriesen jonfriesen changed the title adds ignore-list command adds ignore-paths command arguments to executor Apr 7, 2021
@jonfriesen jonfriesen changed the title adds ignore-paths command arguments to executor adds ignore-path command arguments to executor Apr 9, 2021
@SaschaSchwarze0
Copy link
Contributor

Is it worth listing the new argument in the project's README?

@jonfriesen
Copy link
Contributor Author

@SaschaSchwarze0 good catch! I'll add it to the README shortly. Thanks :)

@jonfriesen
Copy link
Contributor Author

@SaschaSchwarze0 updated 🙏

@RufusJWB
Copy link

RufusJWB commented Jan 9, 2024

It would be great, if you could sort the command argument description in the README file at the alphabetically correct place. I was searching quite some time for it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuration of extra ignore-list paths
4 participants