Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in kaniko/pkg/util.mkdirAllWithPermissions #1677

Closed

Conversation

zhangguanzhang
Copy link

Signed-off-by: zhangguanzhang zhangguanzhang@qq.com

Fixes #1657

Description

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

@google-cla
Copy link

google-cla bot commented Jun 21, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no CLA not signed by all commit authors label Jun 21, 2021
@zhangguanzhang
Copy link
Author

@googlebot I signed it!

@googlebot I signed it!

@google-cla google-cla bot added cla: yes CLA signed by all commit authors and removed cla: no CLA not signed by all commit authors labels Jun 21, 2021
@zhangguanzhang zhangguanzhang force-pushed the panic-mkdir branch 6 times, most recently from 080b959 to 26db0f8 Compare June 22, 2021 03:19
@Panlq
Copy link

Panlq commented Aug 30, 2021

@zhangguanzhang Do you know how to avoid this bug? Please.

@zhangguanzhang
Copy link
Author

@zhangguanzhang Do you know how to avoid this bug? Please.

I don't know

@tejal29
Copy link
Member

tejal29 commented Oct 19, 2021

Please add tests so I can consider reviewing this.

@zhangguanzhang
Copy link
Author

Please add tests so I can consider reviewing this.

The problem of occasion, I don't know how to write, Golang panic information fan-shaped Ying used the attribute

Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
@imjasonh
Copy link
Collaborator

I think this was fixed in #1813 -- please let me know if that's not the case.

@imjasonh imjasonh closed this Dec 23, 2021
@zhangguanzhang zhangguanzhang deleted the panic-mkdir branch December 24, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIGSEGV in kaniko/pkg/util.mkdirAllWithPermissions
4 participants