Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #1897

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Update readme #1897

merged 1 commit into from
Jan 28, 2022

Conversation

geudrik
Copy link
Contributor

@geudrik geudrik commented Jan 28, 2022

Describes work-around for #1803 - add an example of how to work around issues encountered out of the box when trying to pass build-args that contain spaces in their values

Fixes # in case of a bug fix, this should point to a bug and any other related issue(s)

Description

Describes how to pass values to build-args that contain spaces

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [NA] Includes unit tests
  • [NA] Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • [NA] The code flow looks good.
  • [NA] Unit tests and or integration tests added.

Release Notes

Added an example of how to pass build-args that contain spaces in their values (ref: #1803 )

Describes work-around for GoogleContainerTools#1803 - add an example of how to work around issues encountered out of the box when trying to pass build-args that contain spaces in their values
@geudrik
Copy link
Contributor Author

geudrik commented Jan 28, 2022

I just signed the CLA, but I think someone else will need to re-run that test.

@imjasonh imjasonh merged commit 87bed14 into GoogleContainerTools:main Jan 28, 2022
@imjasonh
Copy link
Collaborator

Thanks for your contribution! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants