fix(Dockerfile): use temporary busybox mount to create /kaniko directory #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
June 28, 2022 09:28
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
This reverts commit 8923941.
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
…mount Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
|
Somethings seems to be odd when building on s390x platform: https://github.com/GoogleContainerTools/kaniko/runs/7092430574?check_suite_focus=true#step:7:271 |
|
This came up before: #1749 |
imjasonh
approved these changes
Jun 28, 2022
added 3 commits
June 28, 2022 19:41
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
|
I chose to use busybox with musl libc because the binaries are staticly compiled for all platforms. This removes the need to import /lib on certain architectures which is hard to maintain. |
4 tasks
|
Needs #2154 to be merged for successful builds. |
imjasonh
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes breaking builds introduced in #2009 and issue #1363
Description
Using a locally generated tarball introduced errors on builds, that are not run using the make target images.
This PR uses buildkits mount feature to temporary mount busybox in order to create the /kaniko directory with rwx permissions.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes