fix(WORKDIR): use the config.User for the new dir permissions #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
arisro
force-pushed
the
fix/workdir-perms
branch
from
09ff0a9
to
76edee9
Compare
imjasonh
reviewed
Sep 27, 2022
WORKDIR ignores the currently set USER and creates the new directories with the root user ownership. This changes that, by executing a chown after the mkdir if needed, and also handle the case where the provided USER is an uid and the passwd file is not available to resolve to the username. Fixes GoogleContainerTools#2259 Signed-off-by: Aris Buzachis <buzachis.aris@gmail.com>
arisro
force-pushed
the
fix/workdir-perms
branch
from
76edee9
to
79b7da0
Compare
imjasonh
approved these changes
Sep 28, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2259, probably #477, probably #1340 (does not repro anymore)
Description
WORKDIR ignores the currently set USER and creates the new directories with the root user ownership.
This changes that, by executing a chown after the mkdir if needed, and also handle the case where the provided USER is an uid and the passwd file is not available to resolve to the username.
The PR contains a smoke integration test as the container-diff cannot yet check file ownership (GoogleContainerTools/container-diff#308) - it just makes sure the build does not error out for various cases and that the diff looks good.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes